ci: add dual build artifacts for Windows (min-rust vs migrations)#2208
Merged
ci: add dual build artifacts for Windows (min-rust vs migrations)#2208
Conversation
Add $(ExtraDefines) to PreprocessorDefinitions in all 4 configurations of the vcxproj. This allows passing /p:ExtraDefines=DISABLE_RUST from the MSBuild command line to use C code paths for switchable modules. The Windows CI now produces two Release artifacts per architecture: - "CCExtractor Windows x64 Release build" — min Rust (DISABLE_RUST) - "CCExtractor Windows x64 Release build (with migrations)" — max Rust The migrations build uses /t:Rebuild to do a clean rebuild without DISABLE_RUST after the min-rust build completes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 578abca...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$(ExtraDefines)toPreprocessorDefinitionsin all 4 vcxproj configurations (Debug-Full/Release-Full x Win32/x64), empty by default (no-op)/p:ExtraDefines=DISABLE_RUST) →CCExtractor Windows x64 Release build(existing artifact name)CCExtractor Windows x64 Release build (with migrations)(new artifact)How it works
The vcxproj now includes
$(ExtraDefines)at the start of eachPreprocessorDefinitions. When the CI passes/p:ExtraDefines=DISABLE_RUST, the C code paths are used for switchable modules (DTVCC, demuxer, AVC, networking). The Rust library still links for Rust-only modules. The migrations build uses/t:Rebuildfor a clean rebuild without the flag.Test plan
🤖 Generated with Claude Code